edk2 icon indicating copy to clipboard operation
edk2 copied to clipboard

DynamicTablesPkg: Adds ACPI FADT Table generator

Open abdattar opened this issue 1 year ago • 1 comments

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4781

Adds generic ACPI FADT table generator library. Register/Deregister FADT table. Adds Arch namespace ids. Update the FADT table during boot as per specification.

Cc: Sami Mujawar [email protected] Cc: Pierre Gondois [email protected]

Description

Adds generic FADT table generator. Adds arch-specific FadtUpdate.c to select arch-specific tokens. This patch is required for X64 platform to generate FADT table.

  • [ ] Breaking change?
    • Breaking change - Will this cause a break in build or boot behavior?
    • Examples: Add a new library class or move a module to a different repo.
  • [ ] Impacts security?
    • Security - Does the change have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • [ ] Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Unit testing is done on X64 platform. CI will cover for all platform

Integration Instructions

N/A

abdattar avatar May 31 '24 04:05 abdattar

Please review the code changes.

abdattar avatar May 31 '24 07:05 abdattar

Hello Abdul, Now that the reorg has been merged, I think you can create a PR based on https://github.com/pierregondois/edk2/pull/2 on the main repo.

Maybe just one thing about DynamicTablesPkg: Defines generic table generator creator id and TABLE_GENERATOR_CREATOR_ID, I think it might be better to drop it for now as it is still unclear who should be able to configure the creator Id of the ACPI tables

pierregondois avatar Jul 30 '24 13:07 pierregondois

PR can not be merged due to conflict. Please rebase and resubmit

mergify[bot] avatar Jul 30 '24 13:07 mergify[bot]

Thanks @pierregondois and @samimujawar for upstreaming the acpi dynamic tables reorg. Sure, I 'll re-work and submit the patch on master branch.

Thanks AbduL

abdattar avatar Jul 31 '24 08:07 abdattar

opened another PR https://github.com/tianocore/edk2/pull/6015 closing this Pr.

abdattar avatar Jul 31 '24 11:07 abdattar