edk2
edk2 copied to clipboard
DynamicTablesPkg: Enhance SPCR support for interrupt and terminal types
Introduce optional configuration objects to specify interrupt and terminal types. When the platform supplies this information, the SPCR table is updated to reflect the provided values.
If the interrupt type is 8259, the corresponding IRQ number is set in the SPCR table.
Description
Adds common configuration objects for terminal and interrupt type information. Adds corresponding parser. Update Spcr table to optionally read the terminal and interrupt type information. Adds function to validate the terminal and interrupt type information. Update the Spcr table accordingly.
- [ ] Breaking change?
- Breaking change - Does this PR cause a break in build or boot behavior?
- Examples: Does it add a new library class or move a module to a different repo.
- [ ] Impacts security?
- Security - Does this PR have a direct security impact?
- Examples: Crypto algorithm change or buffer overflow fix.
- [ ] Includes tests?
- Tests - Does this PR include any explicit test code?
- Examples: Unit tests or integration tests.
How This Was Tested
Tested on AMD platform.
Integration Instructions
N/A
PR can not be merged due to conflict. Please rebase and resubmit
Fixed CI failure.
Hi @pierregondois I had addressed the review comments and also added validation and support for EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS port type.
@mergifyio requeue
requeue
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically
@mergifyio update
update
☑️ Nothing to do, the required conditions are not met
- [ ]
#commits-behind > 0[📌 update requirement] - [X]
-closed[📌 update requirement] - [X]
-conflict[📌 update requirement] - [X]
queue-position = -1[📌 update requirement]
@mergifyio rebase
rebase