edk2 icon indicating copy to clipboard operation
edk2 copied to clipboard

Published 20 hours ago • verified publisher icon tianocore

Adding FF-A memory management library

Open kuqin12 opened this issue 6 months ago • 7 comments
trafficstars

Description

This change adds the FF-A memory management protocol implementation according to https://developer.arm.com/documentation/den0140/latest/

  • [ ] Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • [ ] Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • [ ] Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

This change was tested on QEMU SBSA and proprietary hardware with Hafnium as the SPMC.

Integration Instructions

Add ArmFfaMemMgmtLib|MdePkg/Library/ArmFfaMemMgmtLib/ArmFfaMemMgmtLib.inf to platform DSC.

kuqin12 avatar May 14 '25 23:05 kuqin12

Hmm... I realise this is a draft, but we should probably get some dedicated maintainers assigned for these libraries/drivers, for when it's not.

leiflindholm avatar May 20 '25 14:05 leiflindholm

Hmm... I realise this is a draft, but we should probably get some dedicated maintainers assigned for these libraries/drivers, for when it's not.

I'd like to help reviewing FFA related changes, at least to keep myself in the loop. But I think folks from ARM would also need to be on the list.

kuqin12 avatar May 20 '25 20:05 kuqin12

Hmm... I realise this is a draft, but we should probably get some dedicated maintainers assigned for these libraries/drivers, for when it's not.

Hi Leif, I can help with this and maybe even @LeviYeoReum. Regards, Sami Mujawar

samimujawar avatar May 21 '25 07:05 samimujawar

Excellent. Could someone submit (or maybe just tag onto this set before it flips out of draft) a stanza for Maintainers.txt?

leiflindholm avatar May 21 '25 10:05 leiflindholm

Excellent. Could someone submit (or maybe just tag onto this set before it flips out of draft) a stanza for Maintainers.txt?

Okay, I will create one in the morning.

kuqin12 avatar May 22 '25 08:05 kuqin12

@samimujawar This PR is updated per requested. Could you please re-review the change? Thanks!

kuqin12 avatar Jun 17 '25 08:06 kuqin12

@lgao4 @mdkinney Could you please help reviewing the change from MdePkg perspective? Thanks in advance!

kuqin12 avatar Jun 18 '25 17:06 kuqin12

@lgao4 @mdkinney Could you please help reviewing the change from MdePkg perspective? Thanks in advance!

I have only one minor comment. I think this change is OK.

lgao4 avatar Jun 20 '25 02:06 lgao4

@leiflindholm @samimujawar @lgao4 this PR is reviewed. May I have help in merging the change when you have a chance? :) Thanks in advance!

kuqin12 avatar Jun 25 '25 18:06 kuqin12

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks.

You may have to fix your CI before adding the pull request to the queue again. If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again. If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify[bot] avatar Jun 26 '25 02:06 mergify[bot]

Updated the patch title per suggestion here: https://github.com/tianocore/edk2/pull/11175#issuecomment-3007946759, to fix the patch check break.

kuqin12 avatar Jun 26 '25 16:06 kuqin12