edk2 icon indicating copy to clipboard operation
edk2 copied to clipboard

Published 20 hours ago • verified publisher icon tianocore

MdePkg: Add MockSynchronizationLib and MockSmmSxDispatch2

Open TsunFengHuang opened this issue 7 months ago • 4 comments

Description

MdePkg: Add MockSynchronizationLib and MockSmmSxDispatch2

  • [ ] Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • [ ] Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • [ ] Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Unit tests component can call these mock functions success

Integration Instructions

N/A

TsunFengHuang avatar May 05 '25 03:05 TsunFengHuang

Hi @lgao4, @mdkinney Would you mind taking some time to review the PR when you have a changce? Thank you!

TsunFengHuang avatar May 22 '25 02:05 TsunFengHuang

The Sx is for Sleep State SMI, not Software SMIs. The description and comments need to be updated.

Also, there is both an SMM and an MM version of this protocol that are identical. This addition of a protocol mock should cover both the SMM and MM versions.

mdkinney avatar May 27 '25 19:05 mdkinney

Hi @mdkinney I have committed a change. Could you kindly review it and let me know if it meets your expectations? Thank you for your time.

TsunFengHuang avatar Jun 02 '25 13:06 TsunFengHuang

Hi @mdkinney, Would you be able to review the PR when you have a moment? Thank you!

TsunFengHuang avatar Jun 11 '25 03:06 TsunFengHuang

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Aug 10 '25 23:08 github-actions[bot]

PR can not be merged due to conflict. Please rebase and resubmit

mergify[bot] avatar Aug 10 '25 23:08 mergify[bot]

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Oct 11 '25 23:10 github-actions[bot]

This pull request has been automatically been closed because it did not have any activity in 60 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

github-actions[bot] avatar Oct 19 '25 23:10 github-actions[bot]