edk2-test icon indicating copy to clipboard operation
edk2-test copied to clipboard

uefi-sct/SctPkg: EFI_ADAPTER_INFORMATION_PROTOCOL Test

Open Archi1986 opened this issue 11 months ago • 1 comments

The EFI_ADAPTER_INFORMATION_PROTOCOL Test 5.5.11.1.2 always FAILS with the AIP Support Type gEfiAdapterInfoNetworkBootGuid.

In the Guid C file, gEfiAdapterInfoUndiIPv6SupportGuid is assigned to an incorrect Guid.

Thanks.

uefi-sct\SctPkg\TestCase\UEFI\EFI\Protocol\AdapterInfo\BlackBoxTest\AdapterInfoBBTestMain.c

BOOLEAN
InfoTypeAndBlockSizeCmp( 
  EFI_GUID    InformationType,
  UINTN       InformationBlockSize
  )
{
   
  if ((!GuidCmp (InformationType,gEfiAdapterInfoMediaStateGuid) && InformationBlockSize != sizeof(EFI_ADAPTER_INFO_MEDIA_STATE)) || 
      (!GuidCmp (InformationType,gEfiAdapterInfoNetworkBootGuid) && InformationBlockSize != sizeof(EFI_ADAPTER_INFO_NETWORK_BOOT)) || 
      (!GuidCmp (InformationType,gEfiAdapterInfoSanMacAddressGuid) && InformationBlockSize != sizeof(EFI_ADAPTER_INFO_SAN_MAC_ADDRESS)) ||
      (!GuidCmp (InformationType,gEfiAdapterInfoUndiIPv6SupportGuid) && InformationBlockSize != sizeof(EFI_ADAPTER_INFO_UNDI_IPV6_SUPPORT)) ||
      (!GuidCmp (InformationType,gEfiAdapterInfoMediaTypeGuid) && InformationBlockSize != sizeof(EFI_ADAPTER_INFO_MEDIA_TYPE))) 
    return FALSE;
  else
    return TRUE;  
}

uefi-sct\SctPkg\TestCase\UEFI\EFI\Protocol\AdapterInfo\BlackBoxTest\Guid.c

EFI_GUID gEfiAdapterInfoMediaStateGuid              = EFI_ADAPTER_INFO_MEDIA_STATE_GUID;

EFI_GUID gEfiAdapterInfoSanMacAddressGuid           = EFI_ADAPTER_INFO_SAN_MAC_ADDRESS_GUID;

EFI_GUID gEfiAdapterInfoNetworkBootGuid             = EFI_ADAPTER_INFO_NETWORK_BOOT_GUID;

EFI_GUID gEfiAdapterInfoUndiIPv6SupportGuid         = EFI_ADAPTER_INFO_NETWORK_BOOT_GUID;

Archi1986 avatar Jan 24 '25 17:01 Archi1986

Hi @Archi1986 , Thank you for reporting this bug. Could you please submit the solution patch for the same.

edhay avatar Feb 06 '25 15:02 edhay

@Archi1986 and @edhay It looks like the fix has been merged. Can we close the issue? Or is there anything else we need to work on?

sunnywang-arm avatar Jul 03 '25 14:07 sunnywang-arm

I don't have any further questions at the moment.

@edhay , do you have anything to add?

Archi1986 avatar Jul 04 '25 05:07 Archi1986

The issue in the EFI_ADAPTER_INFORMATION_PROTOCOL Test 5.5.11.1.2 has been resolved. If there are any other topics that need to be discussed, please feel free to open a new thread. Thank you all for your support!

Archi1986 avatar Jul 05 '25 10:07 Archi1986