edk2-test icon indicating copy to clipboard operation
edk2-test copied to clipboard

uefi-sct/SctPkg: Fix copy mem build error

Open baranee opened this issue 1 year ago • 7 comments

Use SctCopyMem instead of EfiCommonLibCopyMem

Signed-off-by: Anbazhagan Baraneedharan [email protected]

baranee avatar Dec 11 '24 19:12 baranee

@edhay For some reason, am not able to add reviewers on this PR.

baranee avatar Dec 12 '24 03:12 baranee

Hi @baranee ,

Okay. Could you please raise this issue and submit the patch at the edk2-test mailing list. https://edk2.groups.io/g/devel/messages The patch shall be reviewed in the mailing list.

Also please raise a bug in https://bugzilla.tianocore.org/buglist.cgi?component=UEFI-SCT&list_id=32587&product=EDK2%20Test&resolution=---

Please feel free to contact me for any assistance.

Reference: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers

edhay avatar Dec 17 '24 19:12 edhay

Hi @baranee, What is the build error seen? Also please raise this issue and submit patch in the edk2 message group.

edhay avatar Feb 06 '25 15:02 edhay

@edhay Undefined error on EfiCommonLibCopyMem. Since bugzilla.tianocore.org is down for a while, I thought it's only thru PR at this point. SctPkg\Library\SctLib\Hob.c(388): error C2220: the following warning is treated as an error SctPkg\Library\SctLib\Hob.c(388): warning C4013: 'EfiCommonLibCopyMem' undefined; assuming extern returning int

baranee avatar Feb 06 '25 22:02 baranee

@edhay and @baranee,

I also observe this issue on cross compiliinf, with arm 14.2 toolchain (arm-gnu-toolchain-14.2.rel1-x86_64-aarch64-none-linux-gnu), but same is not observed with 13.2 toolchain (arm-gnu-toolchain-13.2.Rel1-x86_64-aarch64-none-linux-gnu)

chetan-rathore avatar Feb 23 '25 04:02 chetan-rathore

@chetan-rathore Thanks for confirming similar issue in arm tool chain build. @edhay any other process needs to be followed to merge this PR?

baranee avatar Mar 04 '25 13:03 baranee

I have the same problem here, this actually fixes it :)

luigix25 avatar Mar 17 '25 10:03 luigix25