edk2-edkrepo icon indicating copy to clipboard operation
edk2-edkrepo copied to clipboard

[Enhancement] extend edkrepo log command line argument

Open chrisyly opened this issue 2 years ago • 2 comments

Brief: Introduce more kwargs option in "edkrepo log" command

Command "edkrepo log" is defined under:

  • edk2-edkrepo/edkrepo/commands/log_command.py

It retrieve commit messages through gitpython module called under:

  • edk2-edkrepo/edkrepo/commands/common_repo_functions.py -> sort_commits()

The API being used from gitpython is Repo.iter_commits()

  • from implementation, sort_commits feeds either empty argument or max_count to iter_commits
  • The API "iter_commits" doc "https://gitpython.readthedocs.io/en/stable/reference.html" indicate it can accept all argument from git-rev-list

Hence iter_commits could accept more argument such as:

  • iter_commits("origin/master..HEAD")
  • majority of the git log arguments

Feature request:

  • Adding kwargs to iter_commits to extend "edkrepo log" command line option Result:
  • "edkrepo log" can be more "git log" like command

chrisyly avatar Mar 25 '22 17:03 chrisyly