edk2-basetools icon indicating copy to clipboard operation
edk2-basetools copied to clipboard

Fix compilation database generator

Open brandonaut opened this issue 2 years ago • 4 comments
trafficstars

Add source file to the command. The compilation database format requires including the source file name in the command, since the command must be the full command used to compile. When the source file is absent, it can break tools that use the compilation database, such as SonarQube.

brandonaut avatar Apr 20 '23 19:04 brandonaut

Codecov Report

Patch coverage has no change and project coverage change: -0.01 :warning:

Comparison is base (fd9ae0a) 4.28% compared to head (e95a60a) 4.27%.

:exclamation: Current head e95a60a differs from pull request most recent head 0519ee8. Consider uploading reports for the commit 0519ee8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #96      +/-   ##
=========================================
- Coverage    4.28%   4.27%   -0.01%     
=========================================
  Files         181     181              
  Lines       81538   81543       +5     
=========================================
  Hits         3490    3490              
- Misses      78048   78053       +5     
Flag Coverage Δ
Linux 4.27% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
edk2basetools/build/BuildReport.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 20 '23 19:04 codecov[bot]

Could you squash the typo fix into the main commit please?

bcran avatar Apr 25 '23 13:04 bcran

Is anyone else following this request? I think it should be merged.

yorange1 avatar Jan 11 '24 17:01 yorange1

Can you help review this PR? @BobCF

yorange1 avatar Jan 15 '24 09:01 yorange1