cot-gan icon indicating copy to clipboard operation
cot-gan copied to clipboard

Question about the Generator

Open acphile opened this issue 3 years ago • 1 comments

Dear authors:

Thank you for your nice work! I have a question about how the generator works in your code. It seems that the generator should take the random variables z only to generator a fake example G: Z->X. However, in your code, I find that the generator actually takes z and information from real examples x to generate G: (Z, Hx)->X https://github.com/tianlinxu312/cot-gan/blob/12f48be0b34fde8371e1ae545cddc9220244f921/toy_train.py#L164 https://github.com/tianlinxu312/cot-gan/blob/12f48be0b34fde8371e1ae545cddc9220244f921/gan.py#L1412 I doubt if it is correct.

I look forward to your reply. Thank you

acphile avatar May 17 '21 04:05 acphile

Dear authors:

Thank you for your nice work! I have a question about how the generator works in your code. It seems that the generator should take the random variables z only to generator a fake example G: Z->X. However, in your code, I find that the generator actually takes z and information from real examples x to generate G: (Z, Hx)->X https://github.com/tianlinxu312/cot-gan/blob/12f48be0b34fde8371e1ae545cddc9220244f921/toy_train.py#L164

https://github.com/tianlinxu312/cot-gan/blob/12f48be0b34fde8371e1ae545cddc9220244f921/gan.py#L1412

I doubt if it is correct. I look forward to your reply. Thank you

Hi,

Sorry that the previous code was messed up with another version of COT-GAN we were developing. The current version should be correct. Thanks for asking.

Best,

Tianlin

tianlinxu312 avatar Jun 29 '21 12:06 tianlinxu312