typer icon indicating copy to clipboard operation
typer copied to clipboard

preserve enum case

Open avaldebe opened this issue 2 years ago • 5 comments

fixes #570: Enum values that differ in case get conflated

avaldebe avatar Mar 21 '23 11:03 avaldebe

📝 Docs preview for commit a933d9115ba5649d38629fe31f1750809d80a3c9 at: https://64199c483889490814ce2f68--typertiangolo.netlify.app

github-actions[bot] avatar Mar 21 '23 12:03 github-actions[bot]

📝 Docs preview for commit 43a56b8c399e0eb3bf11425e9fdb84fea6a74578 at: https://6419a27ba36fd00c80fd7b0a--typertiangolo.netlify.app

github-actions[bot] avatar Mar 21 '23 12:03 github-actions[bot]

📝 Docs preview for commit a0061c9e37ad5ad342dd6c561d7084b915d0f9f2 at: https://649016e778649d3efba5baf1--typertiangolo.netlify.app

github-actions[bot] avatar Jun 19 '23 08:06 github-actions[bot]

Is there any reason why this has yet to be merged? Can I help?

krzysztofwos avatar Aug 14 '23 10:08 krzysztofwos

Is there any reason why this has yet to be merged? Can I help?

Is there something I should do? I updated my branch once, should I do it again?

avaldebe avatar Aug 14 '23 10:08 avaldebe

📝 Docs preview for commit 40e2e924aea227e7e3b4d82f5b0457c44df9eee0 at: https://7cb850dc.typertiangolo.pages.dev

github-actions[bot] avatar Mar 06 '24 17:03 github-actions[bot]

📝 Docs preview for commit 47520b3cff3b3246516baf39ce4ff2b92f02bdbf at: https://ec1ef388.typertiangolo.pages.dev

github-actions[bot] avatar Mar 06 '24 17:03 github-actions[bot]

📝 Docs preview for commit 0efe55c934354f697b28d85b9f4d5b55ec77d24f at: https://583ed24c.typertiangolo.pages.dev

github-actions[bot] avatar Mar 11 '24 15:03 github-actions[bot]

📝 Docs preview for commit caecbd2660dba0ee1f25a328ef22fad301931277 at: https://68497888.typertiangolo.pages.dev

github-actions[bot] avatar Mar 11 '24 15:03 github-actions[bot]

After internal discussion with @tiangolo, I updated the PR further to use the same example from the docs, and to add a note to the documentation. The current documentation has a specific section on how to make the enums case insensitive, which seems to confirm that the current behaviour on master is indeed a bug, and that the enum should be case sensitive by default as in this PR.

svlandeg avatar Mar 11 '24 15:03 svlandeg

📝 Docs preview for commit 53a94e43df459917998a5b4540c15541532b43bc at: https://8461de1d.typertiangolo.pages.dev

github-actions[bot] avatar Mar 11 '24 15:03 github-actions[bot]

Awesome, thanks @avaldebe! :rocket:

And thanks @krzysztofwos for the report. :nerd_face:

Also, thanks @svlandeg for the help! :bow:

This will be available in Typer 0.9.1 in the next few hours. :rocket:

tiangolo avatar Mar 23 '24 13:03 tiangolo