typer
typer copied to clipboard
Speedy try at letting command/cb functions be async/awaitable
Seems to work. Modified one of your (@tiangolo) test files.
The only thing that is funky is the click 2-3 param warning I get when doing something with context.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
f5682d3
) to head (a4116e1
). Report is 252 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 242 243 +1
Lines 4502 4634 +132
==========================================
+ Hits 4502 4634 +132
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please refrain from including code formatting in this PR.
It's very hard to review the changes this way.
@thedrow I used the script for formatting. I think my wsl git changed the file permissions which makes git think the whole of a file(s) was/were changed
Is this still on the slate for inclusion or is this OBE?
Closing this PR in favour of https://github.com/tiangolo/typer/pull/213 which contains a more clean version of the diff. Thanks for your contribution @jessekrubin and apologies for taking so long to engage with this! We'll continue the review over at #213.
@svlandeg no prob. The formatting got all screwy (I think bc I was on a wonky computer).