typer icon indicating copy to clipboard operation
typer copied to clipboard

✨Adds the ability to use union in type signatures

Open arielf212 opened this issue 10 months ago • 5 comments

This PR adds the ability to use real unions (a la Union[int, str]), as requested in #461.

I am new to contributing to this Repository, and I'll happily add anything I might have missed (docs/tests/incorrect code location/etc).

arielf212 avatar Feb 07 '25 13:02 arielf212

I am setting this to draft for now since I have no idea whether what I did is enough, I'll happily convert this to a merge request once someone will give me the OK.

arielf212 avatar Feb 07 '25 13:02 arielf212

@svlandeg I don't mean to be rude, but is there any progress on getting this in? I haven't been able to find any docs talking about a release cycle, or anything else of sort.

arielf212 avatar Feb 22 '25 12:02 arielf212

Hi @arielf212, thanks for your contribution adding this feature and an appropriate test! 🙏

We're currently working through a bit of a backlog of PRs, so unfortunately it may take a little while to get this properly reviewed by the team. We've put it on our internal board though, so we'll let you know here once we've been able to go through it in detail. Thanks for your patience!

svlandeg avatar Feb 26 '25 07:02 svlandeg

In the meantime, what would be helpful is if you can update the test suite to test all new lines of code, so that the coverage of the code base is back to 100% and the CI goes green again 🙏

svlandeg avatar Feb 26 '25 08:02 svlandeg

can outside folks contribute to this pr? I'd be happy to take a stab at writing the rest of the tests if that helps

a3ng7n avatar May 08 '25 18:05 a3ng7n

This pull request has a merge conflict that needs to be resolved.

github-actions[bot] avatar Sep 20 '25 07:09 github-actions[bot]

As this PR has been waiting for the original user for a while but seems to be inactive, it's now going to be closed. But if there's anyone interested, feel free to create a new PR.

github-actions[bot] avatar Nov 25 '25 11:11 github-actions[bot]