typer-cli icon indicating copy to clipboard operation
typer-cli copied to clipboard

Update pyproject.toml

Open Patarimi opened this issue 2 years ago • 17 comments

I run in the same problem as #118. This PR seems to fix the problem. Maybe the version number needs to be increased ?

Patarimi avatar May 04 '23 13:05 Patarimi

I think a new version number will be needed too to be published on pypi no?

I also need this, for now I cannot publish a package depending on the new typer version on pypi since my packge also depend on typer-cli (even if typer-cli is only in the dev dependencies).

antoine-de avatar Jun 01 '23 13:06 antoine-de

+1 for this fix!

Is there anything holding it back? I'd be happy to jump in and help if need be!

glass-ships avatar Jun 15 '23 17:06 glass-ships

@tiangolo What is your opinion on this pull request ?

Patarimi avatar Jun 16 '23 15:06 Patarimi

@tiangolo I can see you are hard at work to get fastapi ready for pydantic v2, so I know this could fall to the wayside. That said, I think this is a pretty clean and low stakes change. It would be really helpful to merge this to utilize the documentation generation tool.

FWIW, when using this fork as a dependency ("typer-cli @ git+ssh://[email protected]/Patarimi/typer-cli"), I can verify documentation tool can now be run to generate docs.

rpmcginty avatar Jun 27 '23 18:06 rpmcginty

@tiangolo I would like to relax the version constraints too. The pull request would be helpful for many typer users. We really appreciate if you could take a look at it. Thanks!

yu-iskw avatar Jun 28 '23 02:06 yu-iskw

@tiangolo would you be able to review this change?

rpmcginty avatar Jul 31 '23 16:07 rpmcginty

@tiangolo is it possible to review this?

rpmcginty avatar Sep 25 '23 00:09 rpmcginty

@tiangolo Please approve this PR 🙏

austin-silk avatar Oct 02 '23 11:10 austin-silk

@tiangolo Considering the small size of the changes and the fact that it blocks using the newest versions of typer. we'd appreciate it if you could review this PR 🙏

UltimateLobster avatar Oct 08 '23 16:10 UltimateLobster

+1

vitorquintanilha avatar Oct 19 '23 09:10 vitorquintanilha

+1

fritz-astronomer avatar Oct 27 '23 20:10 fritz-astronomer

6 months later, no word at all... Any updates one way or another?

glass-ships avatar Nov 14 '23 17:11 glass-ships

I found this repo. It is actively maintains and offers more functionalities than typer-cli.

Patarimi avatar Nov 20 '23 10:11 Patarimi

Bumping, @tiangolo this seems like a trivial merge. BTW maybe add some more maintainers to the project so it doesn't die?

trymzet avatar Nov 30 '23 14:11 trymzet

Very sad seeing it in a hanging state. Another try, @tiangolo hope you could find some time to review it.

begemotik avatar Dec 27 '23 10:12 begemotik

Bump!

gianfrancodemarco avatar Jan 11 '24 18:01 gianfrancodemarco

+1 please @tiangolo!

vjeeva avatar Feb 21 '24 19:02 vjeeva

+1 @tiangolo thank you

sixdimensionalarray avatar Mar 03 '24 19:03 sixdimensionalarray

Also going to add my support for this pull request!

aschroede avatar Mar 18 '24 11:03 aschroede

@tiangolo Please merge this change to keep compatibility with typer 0.9.0. We really want to migrate to typer 0.9.0, but this blocks us...

PieterBunnenberg avatar Mar 22 '24 09:03 PieterBunnenberg

I created a discussion for this issue as well: https://github.com/tiangolo/typer-cli/discussions/134

PieterBunnenberg avatar Mar 22 '24 09:03 PieterBunnenberg

Thanks @Patarimi and everyone for the discussion here! :coffee:

Now typer-cli is integrated into typer itself. :rocket:

You no longer need (nor should) install typer-cli, instead install typer, and that's it, you get the typer command and everything.

And all the code is always in sync and up to date with the rest of Typer, etc. :tada:


Meanwhile, and just for compatibility, the same Typer repo also publishes the PyPI package typer-cli with exactly the same version as Typer, but the new typer-cli PyPI package (versions 0.12.1+) doesn't have anything, it just requires typer.

And the new versions of typer include the typer command, and the tools to run scripts, generate docs, etc.

As this repo is no longer relevant, I will archive it soon, everything is now in https://github.com/tiangolo/typer.

Given that, I'll close this one, thanks all! :cake:

tiangolo avatar Apr 06 '24 22:04 tiangolo