sqlmodel icon indicating copy to clipboard operation
sqlmodel copied to clipboard

:arrow_up: Update ruff from 0.2.0 to 0.4.1 and fix deprecated scripts…

Open ryankwondev opened this issue 1 year ago • 2 comments

:arrow_up: Update ruff from 0.2.0 to 0.4.1 and fix deprecated scripts commands

  • Upgraded the "ruff = "0.2.0"" dependency in pyproject.toml to "ruff = "0.4.1"".
  • Due to the ruff version upgrade, using the ruff [dir] format has been deprecated (warning: ruff is deprecated. Use ruff check instead.).
  • Accordingly, updated the commands in format.sh and lint.sh script.
  • The readability of existing files has been improved by applying new rules and formatting.

🚨 DEAR MAINTAINERS,

As a result of the impact of bullet point no. 4, the format of the ... return type has been uniformly changed. If this change is undesirable, it seems that additional formatting rules need to be added.

before:

        bind_arguments: Optional[Dict[str, Any]] = None,
        _parent_execute_state: Optional[Any] = None,
        _add_event: Optional[Any] = None,
    ) -> TupleResult[_TSelectParam]:
        ...

after:

        bind_arguments: Optional[Dict[str, Any]] = None,
        _parent_execute_state: Optional[Any] = None,
        _add_event: Optional[Any] = None,
    ) -> TupleResult[_TSelectParam]: ...

ryankwondev avatar Apr 24 '24 00:04 ryankwondev

(+) I think the cause of the pre-commit process, impact of bullet point no. 4, does not seem to be present in this PR's file diff.

ryankwondev avatar Apr 24 '24 00:04 ryankwondev

📝 Docs preview for commit ceb442eb3273e9ae3fc0d369bfa3e1bc99c1f7ce at: https://188583b9.sqlmodel.pages.dev

github-actions[bot] avatar Apr 24 '24 00:04 github-actions[bot]