sqlmodel icon indicating copy to clipboard operation
sqlmodel copied to clipboard

update async extension and add tests

Open PookieBuns opened this issue 1 year ago • 6 comments

  1. update _init_.py file so import can now be found using from sqlmodel.ext.asyncio import AsyncSession which obeys the import format of sqlalchemy https://github.com/tiangolo/sqlmodel/issues/626#issuecomment-1672311902
  2. add tests to AsyncSession utilizing testcontainers and asyncpg. This could introduce overhead for further testing because it requures a docker container to be spun up
  3. add a create_async_engine function to match its non async port of create_engine

Doesn't really address the documentation part of #626 but adds a few QOL features and sets up an easy testing framework for async features

PookieBuns avatar Aug 10 '23 04:08 PookieBuns

@tiangolo https://github.com/pypa/setuptools/issues/3452 there is an issue with importlib which is causing mkdocs fail to run because importlib-metadata is lower than 4.3.0. Currently the project has importlib-metadata stuck on 4.2.0 due to the fact that mkdocs must be 1.2.x which is causing some checks to fail randomly. Could we update the mkdocs version?

PookieBuns avatar Aug 10 '23 05:08 PookieBuns

📝 Docs preview for commit af84d75a42a491683b0a9709c96fb0475aea2e8b at: https://5fc91ef2.sqlmodel.pages.dev

github-actions[bot] avatar Oct 24 '23 17:10 github-actions[bot]

@tiangolo I have merged 0.0.9 into the PR branch. All tests pass now :)

PookieBuns avatar Oct 24 '23 17:10 PookieBuns

📝 Docs preview for commit fb600730723012fed8313f3a3502016f62064e78 at: https://f6ad04c2.sqlmodel.pages.dev

github-actions[bot] avatar Nov 05 '23 19:11 github-actions[bot]

Fix conflicts

peidrao avatar Nov 19 '23 22:11 peidrao

📝 Docs preview for commit 3e9bfd881ff370c7b7c0977531cf6d77854d8a9b at: https://c7b5a1e8.sqlmodel.pages.dev

github-actions[bot] avatar Nov 20 '23 01:11 github-actions[bot]