Update `Select` and `SelectOfScalar` to inherit cache

Open rabinadk1 opened this issue 3 years ago • 3 comments

Fixes: #189 Original Solution found in https://github.com/tiangolo/sqlmodel/issues/189#issuecomment-1025190094 from @leynier

Feb 04 '22 06:02 rabinadk1

Cool 👌🏼

Feb 04 '22 13:02 leynier

This patch looks good to me.

Apr 15 '22 17:04 carlbordum

Noticed this as well, would be nice to get rid of the warning spam.

LGTM

Apr 19 '22 04:04 oldfielj-ansto

Codecov Report

Merging #234 (75f2d1c) into main (5e0ac5b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files         185      185           
  Lines        6134     6134           
=======================================
  Hits         5993     5993           
  Misses        141      141

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Aug 27 '22 23:08 codecov[bot]

Awesome! Thanks a lot @rabinadk1 and @leynier for the tip! :cake: :coffee:

This will be available in SQLModel 0.0.7, released in the next hours. :tada:

Aug 27 '22 23:08 tiangolo