sqlmodel icon indicating copy to clipboard operation
sqlmodel copied to clipboard

✨ Support SQLAlchemy keyed dict models with Pydantic v2

Open nkrishnaswami opened this issue 11 months ago • 5 comments

To add support for SQLAlchemy mapped collections, I'd like to add a case for dict origins to the Pydantic v2 get_relationship_to implementation. This PR does so, with a test case using a dictionary with collection class attribute_keyed_dict.

nkrishnaswami avatar Feb 06 '25 21:02 nkrishnaswami

Thanks, @svlandeg!

nkrishnaswami avatar Feb 20 '25 14:02 nkrishnaswami

Any update on this? This is a great feature add that I need. For now, I'm setting the requirement to use git at this PR.

dcode avatar Feb 26 '25 21:02 dcode

@svlandeg what is the next step in the process? How do I get this to be reviewed? (Thanks!)

nkrishnaswami avatar Mar 17 '25 15:03 nkrishnaswami

Hi @nkrishnaswami! It's in our review queue, so not much to be done by you at this point in time. We'll get back to you once we've had time to go through this in details 🙏

svlandeg avatar Mar 18 '25 07:03 svlandeg

YW, and thanks for reviewing it!

nkrishnaswami avatar Nov 05 '25 15:11 nkrishnaswami