fastapi icon indicating copy to clipboard operation
fastapi copied to clipboard

⬆ Upgrade Swagger UI - oauth2-redirect.html

Open mirusu400 opened this issue 2 years ago • 3 comments

Pulled from : https://github.com/swagger-api/swagger-ui/blob/master/dist/oauth2-redirect.html

Current oauth redirection template is from commit 9253c0bf03ff83aac7b8a51dc83fe087502eef99, So I pulled from latest commit.

mirusu400 avatar Jul 24 '22 05:07 mirusu400

Codecov Report

Merging #5189 (f5fb246) into master (5c576e4) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #5189   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          532       532           
  Lines        13684     13684           
=========================================
  Hits         13684     13684           
Impacted Files Coverage Δ
fastapi/openapi/docs.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c576e4...f5fb246. Read the comment docs.

codecov[bot] avatar Jul 24 '22 05:07 codecov[bot]

📝 Docs preview for commit f5fb2466248a5f03b50950dffa3e29ff861151f8 at: https://62dcdcb701230220b2afd5c4--fastapi.netlify.app

github-actions[bot] avatar Jul 24 '22 05:07 github-actions[bot]

Hi, I opened almost the same PR to fix a bug with the "authorization_code with PKCE" authentication flow when OpenIdConnect is used. I only realized you created yours after the fact. :sweat_smile:

Normally, I'd close mine, but I feel like we'd miss some valuable context by not including the details I added to my commit message. Would you be open to merging your commit message and mine?

If so I'd be happy to close my PR and leave less work for the maintainers. :slightly_smiling_face:

ypsah avatar Jul 24 '22 10:07 ypsah

Thanks for the effort @mirusu400! :cake:

This was recently solved in another PR, so I'll close this one. But thanks for the effort! :coffee:

tiangolo avatar Sep 03 '22 16:09 tiangolo