fastapi icon indicating copy to clipboard operation
fastapi copied to clipboard

Adding pip step to avoid errors when installing dependencies

Open edisnake opened this issue 1 year ago • 6 comments

Doc improvement for avoiding issues when installing dependencies as contributor.

edisnake avatar Jul 20 '22 17:07 edisnake

Codecov Report

Merging #5181 (660829a) into master (d69b5f3) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #5181   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          535       535           
  Lines        13825     13825           
=========================================
  Hits         13825     13825           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 20 '22 17:07 codecov[bot]

📝 Docs preview for commit 91aca11080fca4979a094e140df88fb281405a90 at: https://62d83863194b980600bb5976--fastapi.netlify.app

github-actions[bot] avatar Jul 20 '22 17:07 github-actions[bot]

Hi @tiangolo please take a look when having a chance, thx!

edisnake avatar Jul 28 '22 13:07 edisnake

If you have a current version of Python, then pip wouldn't be outdated. What version did you have that Flit conflict with?

JarroVGIT avatar Jul 31 '22 12:07 JarroVGIT

If you have a current version of Python, then pip wouldn't be outdated. What version did you have that Flit conflict with?

Python 3.6.9 which meets FastApi requirements as stated on the main page. image

I believe it's important to add the proposed pip upgrade step since I've seen many developers (beginners to seniors) struggling with similar issues in different projects, but it's up to you guys!

edisnake avatar Jul 31 '22 15:07 edisnake

If you have a current version of Python, then pip wouldn't be outdated. What version did you have that Flit conflict with?

Python 3.6.9 which meets FastApi requirements as stated on the main page. image

I believe it's important to add the proposed pip upgrade step since I've seen many developers (beginners to seniors) struggling with similar issues in different projects, but it's up to you guys!

Agreed, this should work on Python 3.6.9, and if this makes sure it works for that supported version, I am all for it to include it in the docs! :)

JarroVGIT avatar Jul 31 '22 17:07 JarroVGIT

Nice thank you @edisnake! :rocket:

And thanks @JarroVGIT for the discussion! :coffee:

tiangolo avatar Aug 26 '22 14:08 tiangolo