fastapi icon indicating copy to clipboard operation
fastapi copied to clipboard

Bump starlette to 0.20.4

Open ShayBox opened this issue 1 year ago • 8 comments

Security vulnerability was fixed in 0.20.3

ShayBox avatar Jul 19 '22 07:07 ShayBox

Codecov Report

Merging #5172 (5703761) into master (ab8988f) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##            master    #5172      +/-   ##
===========================================
- Coverage   100.00%   99.98%   -0.02%     
===========================================
  Files          533      533              
  Lines        13725    13726       +1     
===========================================
- Hits         13725    13724       -1     
- Misses           0        2       +2     
Impacted Files Coverage Δ
fastapi/applications.py 100.00% <100.00%> (ø)
fastapi/security/api_key.py 100.00% <100.00%> (ø)
fastapi/concurrency.py 90.00% <0.00%> (-10.00%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 19 '22 07:07 codecov[bot]

📝 Docs preview for commit 311ff1f056ff9daefb5b8b87f8a46f221ba03bc5 at: https://62d66318990e3f5dfbda7a42--fastapi.netlify.app

github-actions[bot] avatar Jul 19 '22 07:07 github-actions[bot]

[email protected] dropped support for Python 3.6 https://github.com/encode/starlette/pull/1616

ShayBox avatar Jul 19 '22 07:07 ShayBox

Last starlette version that supported Python3.6 is 1.19.1 https://github.com/encode/starlette/blob/0b132ee2b49ae562f96371e50047507a3706ad09/README.md?plain=1#L44

...so version 0.20.4 will never pass the Pyhon3.6 tests since it requires Python3.7+ https://github.com/encode/starlette/blob/0b132ee2b49ae562f96371e50047507a3706ad09/setup.py#L27

bonastreyair avatar Jul 21 '22 09:07 bonastreyair

Yeah this version change would require following and dropping Python 3.6 support

ShayBox avatar Jul 21 '22 19:07 ShayBox

Any chances to push this PR?

mdczaplicki avatar Aug 04 '22 08:08 mdczaplicki

Python 3.6 reached EOL and stopped getting security patches 7 months ago, so it's probably for the best to drop support.

ShayBox avatar Aug 04 '22 08:08 ShayBox

📝 Docs preview for commit 294718a29ae78021b63fd9d5d10fb36ad2239440 at: https://62ecc57b8b5f9f1c3d324fb6--fastapi.netlify.app

github-actions[bot] avatar Aug 05 '22 07:08 github-actions[bot]

Push this PR, please.

Ancieg avatar Aug 12 '22 20:08 Ancieg

📝 Docs preview for commit 57037615b1c2151b3009dcee53db33fb8894c92b at: https://62fed7752cb296161487f364--fastapi.netlify.app

github-actions[bot] avatar Aug 19 '22 00:08 github-actions[bot]

Nobody closed this pull, version has been bumped and Python 3.6 has been dropped.

ShayBox avatar Oct 25 '22 19:10 ShayBox

Thanks for coming back to close it @ShayBox ! ☕

tiangolo avatar Nov 07 '22 14:11 tiangolo