fastapi
fastapi copied to clipboard
Bump starlette to 0.20.4
Security vulnerability was fixed in 0.20.3
Codecov Report
Merging #5172 (5703761) into master (ab8988f) will decrease coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #5172 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 533 533
Lines 13725 13726 +1
===========================================
- Hits 13725 13724 -1
- Misses 0 2 +2
Impacted Files | Coverage Δ | |
---|---|---|
fastapi/applications.py | 100.00% <100.00%> (ø) |
|
fastapi/security/api_key.py | 100.00% <100.00%> (ø) |
|
fastapi/concurrency.py | 90.00% <0.00%> (-10.00%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
📝 Docs preview for commit 311ff1f056ff9daefb5b8b87f8a46f221ba03bc5 at: https://62d66318990e3f5dfbda7a42--fastapi.netlify.app
[email protected] dropped support for Python 3.6 https://github.com/encode/starlette/pull/1616
Last starlette
version that supported Python3.6
is 1.19.1
https://github.com/encode/starlette/blob/0b132ee2b49ae562f96371e50047507a3706ad09/README.md?plain=1#L44
...so version 0.20.4
will never pass the Pyhon3.6
tests since it requires Python3.7+
https://github.com/encode/starlette/blob/0b132ee2b49ae562f96371e50047507a3706ad09/setup.py#L27
Yeah this version change would require following and dropping Python 3.6 support
Any chances to push this PR?
Python 3.6 reached EOL and stopped getting security patches 7 months ago, so it's probably for the best to drop support.
📝 Docs preview for commit 294718a29ae78021b63fd9d5d10fb36ad2239440 at: https://62ecc57b8b5f9f1c3d324fb6--fastapi.netlify.app
Push this PR, please.
📝 Docs preview for commit 57037615b1c2151b3009dcee53db33fb8894c92b at: https://62fed7752cb296161487f364--fastapi.netlify.app
Nobody closed this pull, version has been bumped and Python 3.6 has been dropped.
Thanks for coming back to close it @ShayBox ! ☕