fastapi icon indicating copy to clipboard operation
fastapi copied to clipboard

Add HttpException to avoid overriding

Open bruno-fs opened this issue 3 years ago • 5 comments

This change will allow middlewares interacting with the body parsing process to raise appropriate HTTPExceptions.

bruno-fs avatar Jul 11 '21 20:07 bruno-fs

The commit message should be "Add HttpException to avoid overriding"

Done, @cikay ! Thanks for reviewing

I edited the message and rebased against master branch.

bruno-fs avatar Jan 10 '22 21:01 bruno-fs

The commit message should be "Add HttpException to avoid overriding"

Done, @cikay ! Thanks for reviewing

I edited the message and rebased against master branch.

You can also add the reason to the body of the commit message and change the title of the pull request.

cikay avatar Feb 05 '22 23:02 cikay

@cikay

You can also add the reason to the body of the commit message and change the title of the pull request.

OK. done!

bruno-fs avatar Mar 02 '22 19:03 bruno-fs

Codecov Report

Merging #3519 (af41060) into master (8047230) will decrease coverage by 0.00%. The diff coverage is 50.00%.

@@             Coverage Diff             @@
##            master    #3519      +/-   ##
===========================================
- Coverage   100.00%   99.99%   -0.01%     
===========================================
  Files          532      532              
  Lines        13672    13674       +2     
===========================================
+ Hits         13672    13673       +1     
- Misses           0        1       +1     
Impacted Files Coverage Δ
fastapi/routing.py 99.68% <50.00%> (-0.32%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8047230...af41060. Read the comment docs.

codecov[bot] avatar Jul 06 '22 02:07 codecov[bot]

📝 Docs preview for commit af41060e0c675e2d8d9cc26b6abf11724549a954 at: https://62c4f421fe3373070e80afb3--fastapi.netlify.app

github-actions[bot] avatar Jul 06 '22 02:07 github-actions[bot]