fastapi icon indicating copy to clipboard operation
fastapi copied to clipboard

♻️ Return status_code 409 when item already exists

Open hongjiaherng opened this issue 2 months ago • 2 comments

Typo in docs:

  • Python 3.10+: https://fastapi.tiangolo.com/tutorial/testing/#__tabbed_1_1
  • Python 3.9+: https://fastapi.tiangolo.com/tutorial/testing/#__tabbed_1_2
  • Python 3.8+: https://fastapi.tiangolo.com/tutorial/testing/#__tabbed_1_3

Correct references:

  • Python 3.10+ non-Annotated: https://fastapi.tiangolo.com/tutorial/testing/#__tabbed_1_4
  • Python 3.8+ non-Annotated: https://fastapi.tiangolo.com/tutorial/testing/#__tabbed_1_5

Code snapshot:

@app.post("/items/", response_model=Item)
async def create_item(item: Item, x_token: Annotated[str, Header()]):
    if x_token != fake_secret_token:
        raise HTTPException(status_code=400, detail="Invalid X-Token header")
    if item.id in fake_db:
        raise HTTPException(status_code=400, detail="Item already exists") # NOTE: This should return 409 instead
    fake_db[item.id] = item
    return item

hongjiaherng avatar Apr 30 '24 06:04 hongjiaherng

📝 Docs preview for commit c9d15a29f00b3b9ba01a6b060e361c9498673d75 at: https://4cf3287f.fastapitiangolo.pages.dev

tiangolo avatar Apr 30 '24 06:04 tiangolo

📝 Docs preview for commit b2a88e3d4d4687cb802afefe2c3db268c54f5cbf at: https://f7b2513e.fastapitiangolo.pages.dev

tiangolo avatar Apr 30 '24 14:04 tiangolo