fastapi icon indicating copy to clipboard operation
fastapi copied to clipboard

Update Starlette Min Version

Open alimcmaster1 opened this issue 1 year ago • 1 comments

I don't think we need a max version here, I imagine builds against starlette main would help to diagnose any issues prior to release.

Not sure what Starlette deprecation policy is with respect to breaking changes but we could add a max 0.38 if required.

alimcmaster1 avatar Feb 14 '24 16:02 alimcmaster1

Starlette broke something on FastAPI at some point.

Kludex avatar Feb 15 '24 09:02 Kludex

Thanks for the interest @alimcmaster1, but as FastAPI uses some of the internals from Starlette, we need to keep the constraints a bit closer, there have been issues for not doing it a couple of times in the past. So I'll pass on this one, but thanks for the interest! :coffee:

tiangolo avatar Apr 02 '24 03:04 tiangolo