fastapi-cli icon indicating copy to clipboard operation
fastapi-cli copied to clipboard

feat: 🔧 Add specification of current version of FastAPI dependencies

Open bennie-ferreira opened this issue 1 year ago • 4 comments

I added a way to get the current version of the dependencies instead of getting the hard code version and also did a small refactoring. 🥰

A small contribution from a fan 🫡

bennie-ferreira avatar May 08 '24 01:05 bennie-ferreira

Well, I don't know why "test-redistribute (fastapi-cli-slim)" is failing 🤔

bennie-ferreira avatar May 08 '24 01:05 bennie-ferreira

This is what I was talking about with importlib.metadata. It raises an exception when fastapi-slim is installed instead of fastapi.

$ fastapi --version
Traceback (most recent call last):
  [snip]
  File "/home/messingm/projects/fastapi-cli/src/fastapi_cli/cli.py", line 28, in version_callback
    fastapi_version = version("fastapi")
  File "/home/messingm/.local/share/pdm/python/[email protected]/lib/python3.9/importlib/metadata.py", line 569, in version
    return distribution(distribution_name).version
  File "/home/messingm/.local/share/pdm/python/[email protected]/lib/python3.9/importlib/metadata.py", line 542, in distribution
    return Distribution.from_name(distribution_name)
  File "/home/messingm/.local/share/pdm/python/[email protected]/lib/python3.9/importlib/metadata.py", line 196, in from_name
    raise PackageNotFoundError(name)
importlib.metadata.PackageNotFoundError: fastapi
$ pip3 list | grep fastapi
fastapi-cli-slim  0.0.3   /home/messingm/projects/fastapi-cli
fastapi-slim      0.111.0

mattmess1221 avatar May 08 '24 14:05 mattmess1221

So, I realized this yesterday and found a better solution for it living and learning lol

bennie-ferreira avatar May 08 '24 14:05 bennie-ferreira

@killjoy1221 As soon as I finish my work I'll come back to solve this small problem, thank you for your help and for making me understand

bennie-ferreira avatar May 08 '24 14:05 bennie-ferreira