Tian L.

Results 22 comments of Tian L.

I'm not pretty sure about the practices of markup extension. Adding @guominrui and @hanzhang54 to help review this PR.

Hi @mcooley, the plan looks great. Here are some questions and comments from myself: 1. AFAIK, *unit converter* is sitting at *[CalcManager](https://github.com/microsoft/calculator/tree/main/src/CalcManager)*, and C# cannot connect to it without a...

Since we have `UpdateIsDecimalEnabled()` to take care of the property, consider using it instead of giving a direct value to `IsDecimalEnabled`? Add @xuhongxu96 to help review on this :)

Thanks to @xuhongxu96 for the advice. Hi @DeclanGazil02, it seems this PR contains a number of irrelevant changes. You may open new PRs to describe the motivations (with some simple...

Have you installed the WinAppDriver? It is a fundamental tool that UI test cases rely on. Here is link to the latest (stable) version: https://github.com/microsoft/WinAppDriver/releases/tag/v1.2.1 And other points to pay...

If WinAppDriver is installed properly on your machine, all should be fine. No nuget package is needed. About test settings, for this PR, [CalculatorUITests.ci-internal.runsettings](https://github.com/microsoft/calculator/blob/main/src/CalculatorUITests/CalculatorUITests.ci-internal.runsettings) should be good to use. To...

> 10 tests are failing but due to wrong output. For example `MouseInput_SelectCurrencyWithoutFractionalDigitEnterInputAndCheckTheFormat` is expecting Japanese Yen but is actually outputting Jupiter Gas Money. Jupiter Gas Money is from mocked...

Did you mean these two buttons? ![image](https://github.com/microsoft/calculator/assets/60599517/84e84132-ca68-4a55-a256-c7fb0be40942)

Thank you for proposing this PR, @JacobPoteet. Let me first run the pipeline to check if it passes all the checks. Adding @hanzhang54 @guominrui here to see if they have...