php8.0 BUT READ CARFULLY. THERE'S A BUG

[flobee]

hi. see the test script of the changes Files changed. commented solution for real float tests. something went wrong since ~ c5ce42c

same code base but different coding style AND one disabled test because there is something wrong:

actual branch (my, incl your latest) https://app.travis-ci.com/github/flobee/spss/builds/247089918 php8: https://app.travis-ci.com/github/flobee/spss/jobs/561296016

[lestcape]

Hello, thank you.

I don't know how to package this library. Therefore, I can't make any decisions about it. Please, if you find a fix for a bug, provide it in a separate pull, unrelated to the library's packaging, otherwise, I won't be able to merge the fix.

Thank you also for your understanding.

[flobee]

too long ago... if it helps:

            // $actual = bcsub( sprintf( '%F', $value ), sprintf( '%F', $read->{$key} ) );

            $actual   = @bcsub( (int)$value, $read->{$key});

[lestcape]

Thanks. BCMath may not be enabled by default, so I've tried to eliminate the need for this extension. It's currently only used in the unsignedToSigned and signedToUnsigned functions...

The signedToUnsigned function is not used anywhere and the unsignedToSigned is used only in the bytesToInt function, but bytesToInt is always called without the $unsigned parameter. So, the code of the unsignedToSigned function is never reached really.