youtube-product-reviews-plugin
youtube-product-reviews-plugin copied to clipboard
tiagorbf
Add Turkish translation and trendyol
Greetings,
This is such an awesome project with a great idea, so congrats! I would like to create a Turkish version of it with many Turkish retail websites like trendyol, hepsiburada, gittigidiyor etc.
So, if you are ok with it, I will continue the development of the Turkish version through this branch.
Hey @kerem0comert. I am stoked that you like this simple plugin and that you want to contribute. Would you like to merge your changes into master? For my side, I would love that. But we would need to find a way to allow the user to select their preferred language or even to take it from the browser settings. What do you think of the idea?
I was thinking of two separate plugins, but I guess Chrome Web Store allows for localization just like Google Play, which would justify one universal app. As for the plugin itself, a simple dropdown like UI to change user's language, an input to customize the way Youtube search is performed, or even switches to enable/disable the plugin in certain websites comes time my mind. Some of them could be overkill of course, but it should lead to some fun development, if you are eager to also work on it 🙃 For now I will focus on adding several popular Turkish retail websites which would make the plugin practical.
yes, I am totally in. I think that if we work together we can make a much more complete plugin. Plus there is still a lot we can improve in converting the product title into a searchable query. I just pushed some logic to master that changes the translations according to the browser language. You might have some conflicts now but they should be easy to fix.
Sorry for the delayed response, I had been extremely busy lately. I will be working on what we discussed as they come up. Meanwhile, if you have any improvements, I will be able to update the code base as well.