vnodes icon indicating copy to clipboard operation
vnodes copied to clipboard

Vnodes is not working on Safari

Open scramatte opened this issue 2 years ago • 8 comments

Hello,

Vnodes is not working on Safari Mac or Mobile:

image

Can you fix it ?

Regards

scramatte avatar Dec 11 '22 10:12 scramatte

Thank you for reporting, unfortunately I don't have the mac hardware to fix the problem for now so it may take a while to solve.

tiagolr avatar Dec 12 '22 19:12 tiagolr

It looks like something with your demo...

image

With Chrome

image With Safari on MacOS Bigsur

As you can see only some problem with edges alignmemts.

In all case, If you want, I can give you access to a remote MacOS hardware to fix any issue on these platform. Contact me in private and I send you details.

on iOS is not working. Edges are not connected to ports/nodes and gestures are not supported (for zoom for example). Not sure that touch event works. To handle drag and drop it will be necesary to handle tap, long tap and something more.

IMG_F2D57CD9E4C4-1

Regards

scramatte avatar Dec 13 '22 15:12 scramatte

It works now with Safari ! It was port styles and markup issues... Now we need to get it working on iOS Safari but for this I'll some help from your side.

scramatte avatar Dec 13 '22 19:12 scramatte

I've tested it on Android and displaying is ok but touch events are not working such zoom or drag

scramatte avatar Dec 13 '22 22:12 scramatte

I can try and fix android, iOS I don't have the tools, how did you fix the port styles / markup issues? maybe a PR for that, cheers

tiagolr avatar Dec 14 '22 11:12 tiagolr

About style, I believe tat was just mistake from my side as port shape must me square / circle. It looks that with your demo, Safari doesn't render well various diagram on the same page.

About iOS/Mac I can send you access to remote MacOs with all tools to fix. Including iOS simulator. So you can link Safari with simulator to get debug info you needs.

scramatte avatar Dec 14 '22 12:12 scramatte

Okay, I am not sure when I'll be available but feel free to ping me, I'll be fixing the android touch events meanwhile.

tiagolr avatar Dec 14 '22 17:12 tiagolr

okay, just fixed drag on mobile, also enabled controls for zoom on mobile devices as a workaround since pinch zoom can be tricky to add

tiagolr avatar Dec 14 '22 18:12 tiagolr

Closing this as PR has been merged

tiagolr avatar May 12 '24 15:05 tiagolr