Timo Beckers comments

Results 267 comments of


                                            Timo Beckers

fix: dedup cilium endpoint controllers

I'll convert this to a draft for now since there's unresolved discussion and it looks like things are in limbo. @sypakine If you're still looking for more input, please revive...

docs: document logOptions in cilium install

I've converted this to a draft to get this out of triage/review queues. Please mark as ready once you've addressed the outstanding issues.

CI: Conformance Cluster Mesh (ci-clustermesh): no-unexpected-packet-drops/no-unexpected-packet-drops: `No mapping for NAT masquerade`

Hit this in https://github.com/cilium/cilium/pull/30972 as well (https://github.com/cilium/cilium/actions/runs/8096160769/job/22124400552)

Consolidate network namespace handling

> for now I am leaving each review comment fix commit separate so reviewers can see deltas, given the PR is a bit big and it's hard to sift thru...

Consolidate network namespace handling

@bleggett Heads up, I've squashed and rebased on top of main. I've also made a few changes to the core implementation of the API, building on top of `os.File` instead...

Consolidate network namespace handling

/test

Consolidate network namespace handling

/test

Consolidate network namespace handling

/test

Consolidate network namespace handling

/test

Consolidate network namespace handling

@bleggett Thanks for picking this back up, I fell sick a few weeks ago and didn't manage to continue. I'm taking another look at this now, there's an issue with...