AwesomeValidation icon indicating copy to clipboard operation
AwesomeValidation copied to clipboard

Published 20 hours ago • verified publisher icon thyrlian

Migrate to Kotlin

Open shbhmnk opened this issue 5 years ago • 8 comments

Convert the code base to Kotlin to leverage features provided by the language.

shbhmnk avatar Oct 02 '19 10:10 shbhmnk

Yep, will try to migrate when I got time.

thyrlian avatar Oct 02 '19 11:10 thyrlian

Need a hand? Will shoot some PR your way if that's okay.

shbhmnk avatar Oct 02 '19 19:10 shbhmnk

Sure, please go ahead. Thanks for your contribution.

thyrlian avatar Oct 03 '19 07:10 thyrlian

Hi @thyrlian, I have started working on migrating the project to Kotlin. Here, https://github.com/thyrlian/AwesomeValidation/pull/75 as the initial PR, I have started with few test classes.

Please let me know if you would like any changes in this. I will follow up with rest of the test cases and if all is well then I will start migrating the library as well.

shbhmnk avatar Oct 05 '19 08:10 shbhmnk

Thanks @shubh10 for your PR, will check once I'm free.

thyrlian avatar Oct 06 '19 07:10 thyrlian

@thyrlian sure. Take your time. I'll work on rest of the codebase once we are okay with this.

shbhmnk avatar Oct 06 '19 08:10 shbhmnk

@thyrlian Here is new PR: #84

temirnurdin avatar Jan 04 '21 11:01 temirnurdin

Hey @temirnurdin could you please review https://github.com/thyrlian/AwesomeValidation/pull/75 whenever you get a chance

shbhmnk avatar Jan 10 '21 18:01 shbhmnk