Michał Pierzchała comments

Results 259 comments of


                                            Michał Pierzchała

feat: Support autolinking C++ only TurboModules on Android

Thanks @atlj! Please contact Nico on how this can be ported to the RNGP in core repo

stdout and stderr are written to console out of sync

Could you setup a repro so it's easier to approach this case?

100% CPU usage on --bail & --coverage combination

Agree with @SimenB. I don't see a value in processing coverage for a failed test and related files (if not processed by other code). By doing so, we could also...

Code Coverage doesn't fail with 0% cover.

Please provide a repro somebody can download and triage.

Code Coverage doesn't fail with 0% cover.

It's optional, that's why I'm not closing this issue :) (however I could do it, because you removed quite some important information, like which version of Jest you use, which...

bug: `resetAllMocks` messes up `runAllTimers` when using `useFakeTimers`

@SimenB haven't thought about that either. Would be quite a breaking change with Lolex.

toMatchObject pass when comparing any object to a empty object ({})

Can confirm this is a bug. cc @pedrottimark @mattphillips

toMatchObject pass when comparing any object to a empty object ({})

If this is what we expect and makes sense in general, it should be documented, because it's definitely not obvious. I think we could do better though

toMatchObject pass when comparing any object to a empty object ({})

Since v25 is nearing, I'd stick it there, it's easier to justify breaking behavior (even though fixing bugs) in a major change.