PJAX-Standalone icon indicating copy to clipboard operation
PJAX-Standalone copied to clipboard

Published 20 hours ago • verified publisher icon thybag

'pjax:end' event

Open staabm opened this issue 6 years ago • 3 comments

does this lib intentionally not support the pjax:end which the origin lib does?

staabm avatar Mar 23 '18 13:03 staabm

Ahoy,

Not intentionally at least - I've not had a chance to really look at this lib in quite some time, so its now potentially a few years behind jquery-pjax, and may well be missed some of the newer features.

Although it tries to do same job, it is also a totally different codebase/implementation so does do some things very differently to jquery-pjax.

In this case i suspect the complete event will probably do what you want, as it fires after the HTML on the current page has been updated etc

thybag avatar Mar 23 '18 14:03 thybag

thx for your answer.

the original lib supports complete and end, see https://github.com/defunkt/jquery-pjax#events

would you support changes to this lib which renders it more in-line with the upstream? or wouldn't you accept those changes because of BC concerns?

staabm avatar Mar 23 '18 15:03 staabm

If your happy to do a PR, i have no objection to there being an end event etc.

thybag avatar Apr 04 '18 16:04 thybag