example-bazel-monorepo icon indicating copy to clipboard operation
example-bazel-monorepo copied to clipboard

Published 20 hours ago • verified publisher icon thundergolfer

What is the point of bootstrap_agent.sh

Open smeyerhot opened this issue 3 years ago • 3 comments

Description of the problem / feature request:

It looks like bootstrap_agent.sh does just about nothing. What is the point of this script, and why do you have it in a s3 bucket?

🐛 Bug Report: Expected Behavior

🐛 Bug Report: Actual Behavior

🐛 Bug Report: Steps to Reproduce the Problem

🐛 Bug Report: Specifications

  • Version:
  • Platform:

smeyerhot avatar Aug 08 '21 20:08 smeyerhot

If you look through the history of that file, you'll see it used to install some stuff that I hadn't baked into the AWS AMI, such as the Black Python source code formatter.

Recently I removed the need to install anything, and so the file became a kind of 'no op', but the Buildkite config still expects to find and run that file, so it still exists.

In future I could just remove the config that has Buildkite expecting to run that file, and then remove the file.

thundergolfer avatar Aug 10 '21 00:08 thundergolfer

Ok, fair enough. Is the ami is for the buildkite agent?

smeyerhot avatar Aug 10 '21 01:08 smeyerhot

Yes the AMI is for the Buildkite agent. It's not a nice dev-loop to have to rebuild AMIs, but not bothered to change it for now.

thundergolfer avatar Aug 10 '21 03:08 thundergolfer