bazel-linting-system icon indicating copy to clipboard operation
bazel-linting-system copied to clipboard

Add "no-remote" annotations to avoid putting lint results in the remote-cache.

Open thundergolfer opened this issue 4 years ago β€’ 4 comments

I don't think it'd cause any bugs, but I'm not sure remote-caching these linter actions is that useful.

thundergolfer avatar Nov 11 '19 03:11 thundergolfer

Some formatters are fast (gofmt, clang); others are slow (scalafmt, prettier).

I've definitely seen <1000KLOC codebases that take multiple minutes to format.

pauldraper avatar Jun 01 '20 04:06 pauldraper

Hey Paul, in the context of this "no-remote" issue, are you saying that for slow formatters it would be useful to remote-cache?

thundergolfer avatar Jun 02 '20 02:06 thundergolfer

@thundergolfer I am.

In https://github.com/higherkindness/rules_scala we had a target that created formatted versions of source. Then a test target that compared there two, and a runnable target that applied it.

Fetching a something from cache can be faster than formatting it locally, depending on network/compute resources.

pauldraper avatar Jun 13 '20 02:06 pauldraper

I think you're right. Thanks for adding this pushback.

thundergolfer avatar Jun 14 '20 03:06 thundergolfer