thunderbiscuit

Results 189 comments of thunderbiscuit

I pushed the fix. @rustaceanrob if the tests pass, you squash that last commit into yours, and then rebase on master I think this is ready to go! Will give...

Ok I figured out what the other issue was: the persistence was not compatible between versions, so we needed to add a new resource sqlite db to the Swift tests...

Haha 👍👍. Yeah feel free to squash and rebase. It's a bit big for a commit but whatever. Your other option is to split the source code changes and the...

@reez I can't seem to reproduce the test failures locally... but I've seen this error before. Can't quite remember what the context was. ~~I'll try to run the live CI...

Awesome work everyone!

Just for fun: Binary size when including Kyoto, building the aarch64 binary on macOS using the release-smaller profile (libbdkffi.dylib): 9.7MB Binary size without Kyoto, building the aarch64 binary on macOS...

To answer your questions @rustaceanrob: 1. No I don't think we need a live test on Android if we have one on JVM (moreso because the Android emulators don't currently...

I got it working on the Android example wallet! So far so good. I'll take a closer look at the code before giving the final ACK. My first little API-related...

Oh sweet yes I had not looked at all the methods carefully enough. It was easy to update the app to use that instead. 👍

@rustaceanrob would you mind rebasing this? I think we're getting close to merging, or at least this PR is the next one in line for me.