thunderbird-android icon indicating copy to clipboard operation
thunderbird-android copied to clipboard

Add (or rather declare) support for RFC 6531, the SMTPUTF8 extension.

Open arnt opened this issue 7 months ago • 3 comments

This gives Thunderbird the ability to send messages to/from unicode addresses such as grå@grå.org. The user interface is not changed by this; it will be changed in a subsequent PR.

Thunderbird already supported the addresses substantively, since it uses the String type for addresses. That class has no support for ASCII-only strings, only for unicode strings. In effect, the programming language prevented Thunderbird from being incompatible with unicode addresses.

RFC 6531 requires more than substantive compatibility though, it also requires correct declaration of the addresses in the SMTP protocol, and that's what this commit adds.

arnt avatar May 15 '25 17:05 arnt

Pushed again; the cyclomatic complexity of sentMessage() increased from 15 to 16. I feel that I should perhaps get it down to 10 or so, but I actually left it at 15.

arnt avatar May 15 '25 19:05 arnt

@arnt There are some tests failing, I don't have time this week to look into them. Maybe you have an idea otherwise someone else could look into this, maybe @rafaeltonholo?

wmontwe avatar May 27 '25 12:05 wmontwe

I have time. Not today though, but I can work on this tomorrow and Friday.

arnt avatar May 27 '25 12:05 arnt

@arnt I found the issue with the test and fixed the pr. This is ready to merge.

wmontwe avatar Jul 01 '25 14:07 wmontwe