Export file name branding should be Thunderbird not K-9 mail
Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
App version
8.0b2
Where did you get the app from?
Google Play
Android version
12
Device model
Xiaomi Note 10 Pro
Steps to reproduce
- Go to
Settings/Export settings - Clic
Exportbutton - Check the name proposed for the export file
Expected behavior
thunderbird_settings_YYYY
Actual behavior
k9_settings_YYYY
Logs
No response
Would you like to change that?
The relevant location is:
legacy/core/src/main/java/com/fsck/k9/preferences/SettingsExporter.kt
In line 489, you can find:
private const val EXPORT_FILENAME_PREFIX = "k9_settings_export"
You can change it to:
private const val EXPORT_FILENAME_PREFIX = "thunderbird_settings_export"
Can I make this change and submit a pull request?
The suggested change will lead to K-9 Mail using thunderbird_ as filename prefix. So it doesn't solve the problem. It just shifts the problem from Thunderbird to K-9 Mail.
As for https://github.com/thunderbird/thunderbird-android/issues/8278#issuecomment-2401751883 , it seems some strings should be adapted in Weblate, so the filename prefix could adapt to both products.
As we're shifting our focus towards Thunderbird I'd rather have it look right on the Thunderbird side and accept that it might not be 100% correct for a niche thing like the filename here, but obviously the better approach would be to make it different per app. I'm suspecting this shouldn't be too difficult to do, would love to see someone give it a try!