thunderbird-android icon indicating copy to clipboard operation
thunderbird-android copied to clipboard

Switch to Activity Result API

Open cketti opened this issue 1 year ago • 3 comments

Use the Activity Result API instead of manually calling startActivityForResult() and handling the result in onActivityResult().

cketti avatar Apr 16 '24 10:04 cketti

Hi, I want to work on this.

Edit: Sorry I missed tb-team label. Though this issue seems not complex. If I can still work on it, let me know otherwise.

parneet-guraya avatar Jun 13 '24 13:06 parneet-guraya

@cketti Is this a good first issue someone outside of the team could work on?

kewisch avatar Oct 18 '24 10:10 kewisch

Probably not a good first issue, but should be easy enough. If you want to work on this, please only change one instance per pull request. That'll make it easier for us to review (and suggest an alternative approach should that be necessary).

Side note: Probably not a good idea to set the "status: needs information" label on issues that we don't want to be closed by the automation.

cketti avatar Oct 18 '24 12:10 cketti

Hi guys,

Is anyone working on this? I can deal with it right now if you want, I've already worked with the Result API in the past and it's not complex to replace the deprecated code.

marcRDZ avatar Jan 08 '25 14:01 marcRDZ

Hi @cketti, Next steps may be require some consideration before going on with this.

  • SettingsImportFragment seems to be waiting for a replacement of OAuthFlowActivity with the new api. This view also contains a PasswordPromptDialogFragment using onActivityResult instead of FragmentResultListener. I don't know if both cases are outside the scope of this task.
  • Beside this, other uses of startActivityForResult() (i.e. ManageIdentities, MessageCompose and NotificationSoundPreference) are on the legacy package and may be you don't want to spend time on it.

Anyway I look for your instructions.

marcRDZ avatar Feb 03 '25 14:02 marcRDZ