developer-docs icon indicating copy to clipboard operation
developer-docs copied to clipboard

Add de-XBL info and resources

Open Alecaddd opened this issue 5 years ago • 10 comments

Some add-on developers have to yet convert their code to Custom Elements and remove the deprecated XBL bindings.

We should extend the Remove XBL Bindings section with some code snippets and useful tools: https://developer.thunderbird.net/add-ons/updates/tb68#removed-xbl-bindings

Eg:

  • XBL to Custom Element Converter: https://bgrins.github.io/xbl-analysis/converter/
  • XBL Analysis: https://bgrins.github.io/xbl-analysis/
  • A list of approved bugs with code DIFF to use as reference.

Alecaddd avatar Oct 03 '19 20:10 Alecaddd

about the first link - the text is not always 100% clear when it comes to code which needs to work both with the latest and not-absolutely-latest version. For example:

By adding closemenu="none" to a treecol, the column picker stays open after the display state of associated treecol has been toggled.

Is this safe to do in TB 68? TB 60? I'm guessing yes, but I'm not sure. Same for the dialog changes etc.

eyalroz avatar Oct 03 '19 20:10 eyalroz

Here are some notes I made about doing de-xbl work in the Thunderbird code base.
https://wiki.mozilla.org/Thunderbird/de-xbl It's more a list of reminders to myself of things that might need to be done rather than an explanation of how to do them. And some of it may not be applicable for add-ons, but I thought I'd mention it in case it is helpful.

PaulMorris avatar Oct 03 '19 21:10 PaulMorris

@eyalroz that's an XUL question, this topic is specifically for XBL. For what I know, if these changes are listed in the TB 61-68 section, it probably means are not compatible for TB 60. But don't quote me on that as I'm not 100%.

@PaulMorris Sweet, thanks for sharing. If it's OK with you I'll brutally steal it and add it to the docs.

Alecaddd avatar Oct 03 '19 21:10 Alecaddd

Was this info added in some form @Alecaddd?

ryanleesipes avatar Nov 11 '19 23:11 ryanleesipes

Not yet, sorry, it slipped between the cracks of hundred bugs :sweat_smile:

Alecaddd avatar Nov 11 '19 23:11 Alecaddd

I added the link and made it more visible: https://developer.thunderbird.net/add-ons/tb68/changes#removed-xbl-bindings

Is that ok? I also started to use (↗) as a hint for external links, as the used css does not provide good visibility of external links. The big full width link box no longer works with external links :-(

jobisoft avatar Nov 12 '19 21:11 jobisoft

Thanks for adding these info. I don't think it's necessary to use that extra symbol for external links, it's odd and is not used anywhere else.

Alecaddd avatar Nov 17 '19 19:11 Alecaddd

Do you have an idea how to highlight links inside the text? The CSS from gitbook does not give much visibility and they can be overseen easily.

jobisoft avatar Nov 17 '19 19:11 jobisoft

@jobisoft did you have any luck figuring this out?

ryanleesipes avatar Jan 22 '20 17:01 ryanleesipes

Sadly no, are you facing the same issue? Do you have another idea instead of the little arrow I use? Do you (as the main admin) have access to some hidden CSS options?

I just realized that @Alecaddd suggested to remove the arrow, so if you have somthing else :-)

jobisoft avatar Jan 22 '20 23:01 jobisoft