title for button "trash" and "archive"

[FredFromBordeaux]

Hello,

Depending on the preference "conversations.operate_on_conversations" (by default false), the trash (respectively archive) button on toolbar will be delete (respectively archive) the current message or the current conversation. But, the tooltip is always the same one : "delete (respectively archive) this conversation"

This isn't a big bug, but this will avoid confusion.

Thanks a lot for your add-on ! Frédéric de Bordeaux

---

I can maybe propose to create two new lines in file 'pages.dtd' (in french with this example) :

And add test in file 'stub.xhtml' to select a good tooltip :

  <button title="&stub.trash.tooltip;" onclick="deleteToolbar(event);">
        <span class="trash"></span>
  </button>
  <button title="&stub.archive.tooltip;" onclick="archiveToolbar(event);">
        <span class="archive"></span>
  </button>

  if (isInTab || Prefs.operate_on_conversations)
    _____________
  else _____ ;

[protz]

Hi,

Thanks for reporting this. Do you think you could submit a pull request? I'm currently super-busy right now, but since you've got most of it figured out already :) I think I'd be pretty motivated to integrate this.

Thanks,

jonathan

[Standard8]

We should probably go for "Delete this Conversation" vs "Delete selected messages".

addon/content/conversationHeader.jsx is the place to start looking.

[SaxenaShiv]

Hi, can I work on this issue?

[Standard8]

@Shiv-2712 Sorry for the delay in responding, if you want to work on this, that's fine.