thunder
thunder copied to clipboard
thunder-app
Android "base" font size feels like "small" after recent update
Description
Using the app and changing between "Base" and "Small" for post titles doesn't seem to affect the font size. They feel like the same. "Base" feels like it shrunk.
How to Reproduce
Steps to reproduce the behavior:
- Go to settings, select Base as font size for post titles
- Go to feed page, take screenshot
- Go to settings, select Small as font size for post titles
- Go to feed page, take screenshot
- Compare screenshots and notice that font size seemingly is the same.
Expected Behavior
Fonts "Small" and "Base" differ in size
Screenshots
Device & App Version:
- Device: OnePlus 7T Pro
- OS: Android 11
- Version v0.2.3+16
Additional Context
My guess would be that this is related to: https://github.com/thunder-app/thunder/issues/510
I think we can up the size for the base font size to make it a bit more distinct! Would you prefer the base font size to increase, or for the small font size to decrease?
Hmm, personally I've gotten used to the smaller font size on the home page :sweat_smile: So I could probably switch to small, and then you could maybe bump the base if you want. I do find that the difference between base and large to be quite large (heh) and jarring. So bumping the base would probably be better. :shrug:
The only problem with bumping the base font is that, I'm guessing, it's the one most people use (as it's the default), so changing it now might bother people who are used to that size.
I would advocate for changing small because (a) if people are used to the current small, they can just use base, and (b) I've noticed that some other apps like Sync do have a much smaller font scale by default, so I could see people wanting that here too.
Just my 2₵!
I see your point, it is always uncomfortable to change default values. My suggestion if that turns out to be the case is to lower small like you suggest and maybe add a medium between base and large. Because to me that's where the big jarring gap is.
Is this still an issue, or did it end up being addressed/reverted? My memory is hazy...
@machinaeZER0 You might be remembering #543, which originally increased the size of the base font on Android. We got it back to the original size, but I think that had the unintended consequence of making it the same as small. However, it's pretty much the same size it's been since the beginning of Thunder, which is kind of why I was advocating for making small smaller. 😆😆
Ah, right right. Yeah, small and base do feel like they're fairly similar sizes at the moment, but I'd agree that I like where we landed on the base value :) I'm currently using a combo of base and small partly because they mesh quite well together.
I'd agree with @Ga22be that the jump from base to large is a bit jarring though. Did we talk any more about making large and extra large smaller, or adding another step between base and large?
adding another step between base and large
I like this idea! Perfect spot for a "medium". 😊
An update on this: I've added another option for "medium" which slots between base and large! Some more feedback is needed to tweak the value of this option. Once this comes to a nightly build, I would like to get your feedback on this!
Aside from this, did we want to further tweak any of the existing values (or add more values)? I'm a bit wary of changing the existing values as those are already in release builds, and may frustrate users that have tweaked those settings.
I probably wouldn't change anything established at this point, especially with a new interim size being introduced - I'd drop that in (when you're happy with it) and then probably just see if we get any more size based feedback in general?