thunder icon indicating copy to clipboard operation
thunder copied to clipboard

Image viewer top and bottom bars can't be hidden in landscape mode

Open everdred opened this issue 1 year ago • 5 comments

Description
In the image viewer, while in portrait orientation, long-pressing an image causes the top bar (containing back button) and bottom bar (containing share/download/comment buttons) to hide, resulting in extra space to view the image, as expected.

In landscape orientation, hiding the top and bottom bars via long-press results in the icons disappearing but the bars themselves remaining, leaving very little room to view an image.

Screenshots
image viewed in landscape image zoomed larger than viewable space but smaller than screen after long-pressing to hide bars, icons disappear but bars remain

Device & App Version:

  • OS: Android 13
  • Version: v0.2.3+16

Additional Context
Does not seem to matter whether device is already in landscape mode before opening the image or rotating while it's already open.

everdred avatar Aug 17 '23 16:08 everdred

Another weird issue here (not sure if it's related) is when you have an image that's taller than the screen (so there is padding on the sides). It does not appear behind the top/bottom bars until it gets past a certain threshold.

https://github.com/thunder-app/thunder/assets/7417301/6bba658e-4155-48a1-bcc1-e2ceae21d427

micahmo avatar Aug 17 '23 17:08 micahmo

Is there any chance of this being fixed? It makes Thunder’s usability very limited in landscape mode.

throwawaytime avatar Nov 24 '23 01:11 throwawaytime

@hjiangsu I see you assigned this to yourself in January but I'd be be up for working on the image viewer again.

CTalvio avatar May 02 '24 14:05 CTalvio

Sure! I was going to do a full refactor with this change but haven't had time to do so. I'll assign this to you.

Thanks @CTalvio!

hjiangsu avatar May 02 '24 18:05 hjiangsu

Alright. I really want to add some stuff like the ability to rotate images, view some file data, etc.

I'll try and find some better way to use the image widget that doesn't come with any weirdness while I'm at it.

CTalvio avatar May 02 '24 19:05 CTalvio