thunder icon indicating copy to clipboard operation
thunder copied to clipboard

Refactor post card and removing unnecessary prop-drilling

Open hjiangsu opened this issue 9 months ago • 0 comments

Pull Request Description

This PR will place some additional focus on refactoring the general post card (that handles both compact/card views), and removing unnecessary prop-drilling of parameters.

For some context: there are a few places that I am seeing where we are passing down a lot of parameters (prop-drilling) that can instead be derived from their respective blocs. For example, in PostCardViewComfortable, we are passing down parameters that come from the ThunderBloc (e.g., showEdgeToEdgeImages, showTitleFirst, etc.)

The goal here is to reduce these and instead rely on reading the parameters from the bloc!

This will stay in draft status as it's still a WIP.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • [ ] If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • [ ] Did you use localized strings (and added appropriate descriptions) where applicable?
  • [ ] Did you add semanticLabels where applicable for accessibility?

hjiangsu avatar Mar 08 '25 19:03 hjiangsu