thunder icon indicating copy to clipboard operation
thunder copied to clipboard
verified publisher icon thunder-app

Oauth updates

Open gwbischof opened this issue 1 year ago • 2 comments

Oauth updates. This PR depends on https://github.com/thunder-app/lemmy_api_client/pull/28 This can be tested against the lemmy instance at hopandzip.com which I deployed with the lemmy:main

gwbischof avatar Dec 17 '24 22:12 gwbischof

I just pushed a small change which adds a heading above the OAuth providers (to make it clear what they are and that they're an alternative to non-SSO login), and I also added a little space between each provider.

image

micahmo avatar Jan 14 '25 23:01 micahmo

Nice, the code looks good now! I will try to test if/when I get the chance. If everything is working for you and @hjiangsu, don't worry about waiting for me!

Sounds good, the changes look good to me after a quick review, and I've already tested a previous implementation of this! However, I'm going to hold off on merging this in until v0.20.0 is closer to release, or at least until Lemmy's API changes are more stable (at the moment, it looks like there's still a lot of major changes to the API that we'll need to support eventually).

This way, we can re-test the implementation closer to the next major release!

hjiangsu avatar Jan 16 '25 01:01 hjiangsu