thunder icon indicating copy to clipboard operation
thunder copied to clipboard

Thunder does not load images in comments on instances that proxy images

Open x4740N opened this issue 1 year ago • 2 comments

Bug Description

On instances such as lemm.ee where images are proxied thunder fails to load them

SmartSelect_20240814-012809_Thunder Screenshot_20240814-012722_Thunder SmartSelect_20240814-012709_Thunder

Expected Behaviour

Thunder should load images correctly

Steps to Reproduce

Try to open any image in a comment on a lemmy instance that proxies images such as lemm.ee

Additional Context

No response

App Version

v 0.5-6

Device

Samsung Galaxy A70

OS

Android 11

x4740N avatar Aug 13 '24 15:08 x4740N

Thanks for the report! I forgot to apply the same logic for proxied images in the markdown. I'll apply a patch for this in the general release for v0.5.0.

hjiangsu avatar Aug 13 '24 16:08 hjiangsu

Just a quick update here - it seems like the underlying issue is not with Thunder, but with Lemmy itself. If you visit the comment on Lemmy UI, you'll see that the image is not present there either.

This could likely be an issue with how image proxy handles svg images?

hjiangsu avatar Aug 13 '24 22:08 hjiangsu