thunder icon indicating copy to clipboard operation
thunder copied to clipboard

Arabic Translation not provided.

Open AyaNady17 opened this issue 1 year ago • 3 comments

Bug Description

the Arabic language exists in the UI but there is no translation on the ar.arb file

Expected Behaviour

add the Arabic translation in the l10n file

Steps to Reproduce

add the Arabic translation in the l10n file

Additional Context

No response

App Version

No response

Device

Pixel 4

OS

Android 14

AyaNady17 avatar Feb 20 '24 02:02 AyaNady17

Thanks for the report! Translations are done via Weblate and pushed to the translations branch. After some time, they are then manually pushed into the develop branch on a recurring basis.

It does seem like there are some Arabic translations in the translations branch, so I'll update the develop branch soon to reflect the new localization strings! https://github.com/thunder-app/thunder/blob/translations/lib/l10n/app_ar.arb

hjiangsu avatar Feb 20 '24 17:02 hjiangsu

I can provide the complete Arabic translation for all keywords manually in the l10n file to work immediately without waiting for Weblate . Can you assign it to me? @hjiangsu

AyaNady17 avatar Feb 21 '24 15:02 AyaNady17

Hmm, would it be possible to perform the translations via Weblate, and let me know once thats done? That way, I can go ahead and merge it in when its done!

The one issue with directly modifying the l10n files (aside from the default English file) is that it'll create conflicts with the upstream Weblate repository which are harder to fix

hjiangsu avatar Feb 21 '24 17:02 hjiangsu