thumbprint icon indicating copy to clipboard operation
thumbprint copied to clipboard

[@thumbtack/thumbprint-react]: Modal should be able to maintain full cover on phones in landscape

Open webbower opened this issue 5 years ago • 0 comments

On 4.7" and bigger iPhones in landscape view (or any smartphone with a >700px height), the modal will switch to framed layout when rotated to landscape (medium width breakpoint is exceeded). This results in losing valuable screen real estate in some cases like an image/video gallery where you want to show as much image as possible on the screen (see example in attached screenshot). Not sure if the modal should always be full bleed for landscape on small screens or have it be opt-in via a prop.

iPhone_8_—_12_4

One possible implementation would be to also add a min-height check to the media query to make sure the width and height of the viewport are large enough to warrant adding the framing.

webbower avatar Aug 13 '19 21:08 webbower