pyramid_simpleauth icon indicating copy to clipboard operation
pyramid_simpleauth copied to clipboard

Published 20 hours ago • verified publisher icon thruflo

pyDNS dependency?

Open robertlagrant opened this issue 9 years ago • 3 comments

I'm trying to install on Python 3 on Windows (the least-likely-to-work combination) and while passlib installed fine, it borked on pyDNS. I'm just wondering what that dependency is for, since the only time I see it when I search the repo is in the setup.py file.

Can it be safely removed?

robertlagrant avatar Jul 28 '15 12:07 robertlagrant

Update: it installed fine from https://github.com/robertlagrant/pyramid_simpleauth, where I removed that dep. Will see what happens.

robertlagrant avatar Jul 28 '15 14:07 robertlagrant

Might be something to do with the email validator, which I think has a resolve dns option?

thruflo avatar Jul 28 '15 15:07 thruflo

it looks like PyDNS offers a module named 'DNS', which is not referenced anywhere in the simpleauth source code. can this be fixed, since it's apparently not used? email validation appears to be done using formencode which in turn appears to use dnspython (not PyDNS), but it also does not require it--it will fail the import, issue a warning, and keep going.

matthewblain avatar Apr 15 '16 00:04 matthewblain