threlte icon indicating copy to clipboard operation
threlte copied to clipboard

Docs: clean up Astro component scripts

Open DefinitelyMaybe opened this issue 2 years ago • 3 comments

This PR brings our Astro component scripts inline with how astro does them.

copied patterns were repeated. Anyone know where the { } pattern came from?

---
{
    'category': '@threlte/extras'
    'name': '<Align>'
}
---

vs

---
category: '@threlte/extras'
name: '<Align>'
---

This PR will also make a move to astro+starlight easier. I ran into a wall of errors because of it when trying to make it happen myself.

DefinitelyMaybe avatar Feb 13 '24 22:02 DefinitelyMaybe

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

⚠️ No Changeset found

Latest commit: c4272a0ed97f55adfe910e31346f168e874304a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 13 '24 22:02 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
threlte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 8:53pm

vercel[bot] avatar Feb 13 '24 22:02 vercel[bot]

Should we try doing this in the next branch? Might be easier to get it pushed through there

michealparks avatar Apr 11 '24 03:04 michealparks

Hmm just noticed the new conflicts. I'll do one a merge main commit next week. Hopefully some approval comes, I still have hope 😅

DefinitelyMaybe avatar Apr 11 '24 05:04 DefinitelyMaybe