threlte icon indicating copy to clipboard operation
threlte copied to clipboard

feat: 🎸 Arrow,Axes,Box,Camera and DirectionalLight Helpers

Open takoyaro opened this issue 3 years ago • 4 comments

Added some of the helpers. Does not include the grid helpers nor the other lights.

I also added the docs for each of these but intentionally didn't include them in this PR because the docs behave in a strange way in my environment. image

This is my first "public" PR. Feedback welcome

takoyaro avatar May 16 '22 00:05 takoyaro

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
threlte ✅ Ready (Inspect) Visit Preview May 16, 2022 at 10:59PM (UTC)

vercel[bot] avatar May 16 '22 00:05 vercel[bot]

@grischaerbe this feedback is very appreciated, thank you for your time..!!

Before diving any deeper, I just made the changes you mentioned to the ArrowHelper component and I'd like to know how you feel about it before I apply the changes to the rest of the helpers.

takoyaro avatar May 16 '22 22:05 takoyaro

Just leaving this here, this PR isn't dead. I'm attending a wedding, will be back home on 30th (JST). Will get this done when I'm back home.

takoyaro avatar May 20 '22 08:05 takoyaro

No worries, there's no rush! Actually I was tinkering with it myself and I have to say you picked quite a challenging one :) The ArrowHelper is not that straightforward to implement. I thought it might be nice to be able to also drop in another object as the ArrowHelpers target in order for it to point to that object. Anyway, have fun at the wedding!

grischaerbe avatar May 20 '22 08:05 grischaerbe

Hey @takoyaro! A lot of these helpers are now by nature part of Threlte v5:

<T.ArrowHelper />

grischaerbe avatar Dec 20 '22 12:12 grischaerbe